feat(ivc): protogalaxy::AssignedUnivariatePoly::eval
#379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b26271 to
8dd43eb
Compare
chaosma
reviewed
Oct 30, 2024
|
|
||
| while self.powers.len() <= index { | ||
| let value = self.value(); | ||
| let last = self.powers.last().unwrap(); |
There was a problem hiding this comment.
should each time double the last value instead of multiply by first element? i.e.
{delta, delta^2, delta^4,...}
There was a problem hiding this comment.
Is not related to delta, this is just a cache for x^0, x^1, x^2,....
Doc updated for this method\struct
ef81448 to
cfa85ad
Compare
8dd43eb to
dc5d940
Compare
Base automatically changed from
361-feat-protogalaxy-verify-circuit-3
to
main
November 5, 2024 11:56
chaosma
approved these changes
Nov 5, 2024
**Motivaion** To compute `e` in the framework of #361, we need to be able to compute proof.poly_{F,K} for the on-circuit version **Overview** - Due to the two multiplications within `main_gate`, the polynomial calculation was split into chunks=2 - Since powers of the same values powers will be used in multiple places, its computation has been delegated to a separate struct. This calculation can be optimized (again due to the two multiplications, but it is simpler for speed). - In other tests we test only calculations, since ready-made gadgets are used, here we test everything, since calculations are made directly
dc5d940 to
454f486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivaion
To compute
ein the framework of #361, we need to be able to compute proof.poly_{F,K} for the on-circuit versionOverview
main_gate, the polynomial calculation was split into chunks=2