Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ivc): generate assigned challanges #377

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

cyphersnake
Copy link
Collaborator

@cyphersnake cyphersnake commented Oct 25, 2024

Motivation
Part of #361

Overview

  • Implementation of the same generation challanges as in nifs::protogalaxy mod
  • Consistency test added for challenges generation at {on,off}-circuit env
  • Corrected the number of bits generated for challenges (MAX_BITS will now be used)

Fix poseidon off-circuit hash
Previously, a successive on-circuit poseidon circuit call would cause the old buffer to be reused and the exact same successive off-circuit call would not reuse the previous buffer. Now the behavior has been brought to a uniform standard.

@cyphersnake cyphersnake self-assigned this Oct 25, 2024
@cyphersnake cyphersnake requested a review from chaosma October 28, 2024 14:09
@cyphersnake cyphersnake marked this pull request as ready for review October 28, 2024 14:09
Base automatically changed from 361-refactor-protogalaxy-challenges-generation to main November 4, 2024 11:08
@cyphersnake cyphersnake force-pushed the 361-feat-protogalaxy-verify-circuit-2 branch from abcca31 to 19cc6e5 Compare November 4, 2024 11:11
@cyphersnake cyphersnake merged commit 0990f3d into main Nov 4, 2024
1 check passed
@cyphersnake cyphersnake deleted the 361-feat-protogalaxy-verify-circuit-2 branch November 4, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants