Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl StepCircuitExt logic #36

Closed
wants to merge 15 commits into from
Closed

Impl StepCircuitExt logic #36

wants to merge 15 commits into from

Conversation

cyphersnake
Copy link
Collaborator

@cyphersnake cyphersnake commented Oct 26, 2023 •
edited
Loading

Close #32

@cyphersnake cyphersnake changed the title 32 step circuit ext Impl StepCircuitExt logic Oct 26, 2023
@cyphersnake cyphersnake changed the base branch from main to 9-bitnat-biguint November 1, 2023 11:52
@cyphersnake cyphersnake mentioned this pull request Nov 1, 2023
Merged
Base automatically changed from 9-bitnat-biguint to main November 2, 2023 03:06
@cyphersnake
chore: mv IVC main struct to sep mod
1fce3b5
@cyphersnake
feat(sp): impl SynthesizeStepParams::digest
e970236
@cyphersnake
refactor(ivc): remaster pub-imports
de53247
@cyphersnake
feat(ivc): api draft assigned_relaxed_plonk_instance
c53128a 
WIP: still working with API

Part of #35
@cyphersnake
chore: mv assigned_relaxed_plonk_instance to file
696005d
@cyphersnake
feat(sp): use ROCircuitTrait instead of ROTrait
18e5dc6 
WIP
@cyphersnake
feat(ivc): Assign*->*Chip in relaxed fold
97006b9 
fix(ivc): `BigNat` -> `BigUint`
@cyphersnake
refactor(util): rm unnecessary borrow of ownership
9d234e5 
refactor(util): return `Option` instead of panic

Part of #41

feat: Handle potential errors in field conversions

Updated codebase to handle potential errors when converting between different
 field types in the `fe_to_fe` and `fe_to_fe_safe` functions. Additionally,
_bits_le` and `fe_to_big` have been adjusted to take in references instead of
 values. This ensures that potential conversion errors are properly communicated
 up the call stack, instead of causing a panic.
fe_to
 functions like `
@cyphersnake cyphersnake force-pushed the 32-step-circuit-ext branch 2 times, most recently from c4dcc5d to a7cf4cb Compare November 3, 2023 14:18
@cyphersnake
feat(bn): num_bigint::BigInt -> ::BigUint
dc05bc1 
Internally, the `BigUint` type started to be used instead of `BigInt`,
so as not to have additional sign problems, and since otricial numbers
were not really supported.
@cyphersnake
feat(bn): impl from_assigned_cell_to_limbs
30ff252 
Impl fn with decomposition of one assigned cell into limbs
@cyphersnake
feat(ivc): impl part of fold with mult_mod
f752172
@cyphersnake
doc(ivc): err for fold_relaxed_plonk_instance_chip
c3dc968
@cyphersnake
feat(bn): impl red_mod
5136cf3 
Impl `red_mod` function in the `big_uint_mul_mod_chip` module. The new function takes
 assigned cells as parameters and performs modulus reduction. The result is
 returned as instance of `ModOperationResult` containing the quotient and remainder.
@cyphersnake
Copy link
Collaborator Author

Broken down into other PRs

@cyphersnake cyphersnake deleted the 32-step-circuit-ext branch January 9, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaosma chaosma chaosma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement StepCircuitExt trait methods
2 participants
@cyphersnake @chaosma