Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plonk): algo for permutation #358

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix(plonk): algo for permutation #358

merged 1 commit into from
Oct 2, 2024

Conversation

cyphersnake
Copy link
Collaborator

Motivation
Part #316
The previous algorithm was not accurate, it was losing links to the columns being deleted

Overview

  • Now the columns are sorted even before copy-constraint is added to avoid any double-pointing
  • Added unit-tests

@cyphersnake cyphersnake requested a review from chaosma September 30, 2024 13:10
@cyphersnake cyphersnake self-assigned this Sep 30, 2024
@cyphersnake cyphersnake force-pushed the 316-feat-foldable-wrapper branch from 5a66928 to c41c422 Compare September 30, 2024 13:26
Copy link
Collaborator

@chaosma chaosma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from 316-feat-foldable-wrapper to main October 2, 2024 15:32
**Motivation**
Part #316
The previous algorithm was not accurate, it was losing links to the columns being deleted

**Overview**
- Now the columns are sorted even before copy-constraint is added to avoid any double-pointing
- Added unit-tests
@cyphersnake cyphersnake merged commit 823c9de into main Oct 2, 2024
1 check passed
@cyphersnake cyphersnake deleted the 316-fix-permutation branch October 2, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants