fix(gadgets): bugs in assign_bit #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Motivation** There was a bug, since: - `a` was twice assigned into s[0] rather than into s[0] & s[1] - `q_o` was not assigned at all, but `q_m` was assigned twice. So the actual check did not take place **Overview** Aside from the fix itself, I've refactored a bit to make it more obvious which columns are used within the function
|
Will merge a little later, because of PR-trait around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There was a bug, since:
awas twice assigned into s[0] rather than into s[0] & s[1]q_owas not assigned at all, butq_mwas assigned twice.So the actual check did not take place
Overview
Aside from the fix itself, I've refactored a bit to make it more obvious
which columns are used within the function