feat(ivc): impl instances_accumulator_computation
#353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbd9cfe to
5d227e3
Compare
5d227e3 to
eb6541a
Compare
chaosma
reviewed
Sep 25, 2024
chaosma
approved these changes
Sep 25, 2024
104191e to
11dccdc
Compare
**Motivation** As part of #316, we need to accumulate `instance`, using a poseidon hash. This PR should provide a consistent way to do this {on,off}-circuit within nifs::vanilla **Overview** - New Module - Added `instances_accumulator_computation.rs` to handle the accumulation of `instances` using the Poseidon hash function. - Functions: - `fold_step_circuit_instances_hash_accumulator` for off-circuit hash accumulation. - `fold_assign_step_circuit_instances_hash_accumulator` for on-circuit hash accumulation - Testing: - Added comprehensive unit tests to verify the consistency of the accumulator computation.
3dd4ffe to
698a578
Compare
**Motivation** Practically complete realization of task #316 **Overview** Impl of accumulation of step circuit instances - Addition of a `step_circuit_instances_hash_accumulator` to the `RelaxedPlonkInstance` structure. - Implementation of methods to fold and conditionally select step circuit instances. - Modification of existing methods to incorporate the new accumulator. - Update to testing modules to cover the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of #316, we need to accumulate
instance, using a poseidon hash. This PR should provide a consistent way to do this {on,off}-circuit within nifs::vanillaOverview
instances_accumulator_computation.rsto handle the accumulation ofinstancesusing the Poseidon hash function.fold_step_circuit_instances_hash_accumulatorfor off-circuit hash accumulation.fold_assign_step_circuit_instances_hash_accumulatorfor on-circuit hash accumulation