Skip to content

Commit

Permalink
chore: mark TODO with #32
Browse files Browse the repository at this point in the history
  • Loading branch information
cyphersnake committed Oct 25, 2023
1 parent 8358213 commit c4c1cb5
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions src/ivc/step_circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ impl<const A: usize, F: PrimeField, C: StepCircuit<A, F>> ConfigureWithInstanceC
}
}

// TODO Rename
// TODO #32 Rename
pub(crate) struct SynthesizeStepParams<G: CurveAffine, RO: ROTrait<G>> {
pub limb_width: usize,
pub n_limbs: usize,
Expand All @@ -127,6 +127,7 @@ pub(crate) struct SynthesizeStepParams<G: CurveAffine, RO: ROTrait<G>> {
pub ro_constant: RO::Constants,
}

// TODO #32
pub(crate) struct StepInputs<'link, const ARITY: usize, C: CurveAffine, RO: ROTrait<C>> {
params: &'link SynthesizeStepParams<C, RO>,
step: C::Base,
Expand All @@ -144,7 +145,7 @@ pub(crate) struct StepInputs<'link, const ARITY: usize, C: CurveAffine, RO: ROTr
T_commitment: Option<Vec<C::Scalar>>,
}

// TODO Add other
// TODO #32 Add other
pub(crate) struct AssignedStepInputs<const ARITY: usize, C: CurveAffine> {
params: AssignedCell<C::Scalar, C::Scalar>,
step: AssignedCell<C::Scalar, C::Scalar>,
Expand All @@ -153,7 +154,7 @@ pub(crate) struct AssignedStepInputs<const ARITY: usize, C: CurveAffine> {
zi: [AssignedCell<C::Scalar, C::Scalar>; ARITY],
}

// TODO
// TODO #32
/// Extends a step circuit so that it can be used inside an IVC
///
/// This trait functionality is equivalent to structure `NovaAugmentedCircuit` from nova codebase
Expand All @@ -175,7 +176,7 @@ pub(crate) trait StepCircuitExt<'link, const ARITY: usize, C: CurveAffine>:
// instance along with a boolean indicating if all checks have passed
let _U_non_base = self.synthesize_step_not_base_case(&config, layouter, assigned_input)?;

todo!()
todo!("#32")
}

fn alloc_witness<RO: ROTrait<C>>(
Expand All @@ -184,15 +185,15 @@ pub(crate) trait StepCircuitExt<'link, const ARITY: usize, C: CurveAffine>:
_layouter: &mut impl Layouter<C::Scalar>,
_input: StepInputs<ARITY, C, RO>,
) -> Result<AssignedStepInputs<ARITY, C>, SynthesisError> {
todo!()
todo!("#32")
}

fn synthesize_step_base_case(
&self,
_layouter: &mut impl Layouter<C::Scalar>,
_u: &AssignedCell<C::Scalar, C::Scalar>,
) -> Result<[AssignedCell<C::Scalar, C::Scalar>; ARITY], SynthesisError> {
todo!()
todo!("#32")
}

fn synthesize_step_not_base_case(
Expand All @@ -201,7 +202,7 @@ pub(crate) trait StepCircuitExt<'link, const ARITY: usize, C: CurveAffine>:
_layouter: &mut impl Layouter<C::Scalar>,
_assigned_input: AssignedStepInputs<ARITY, C>,
) -> Result<[AssignedCell<C::Scalar, C::Scalar>; ARITY], SynthesisError> {
todo!()
todo!("#32")
}
}

Expand Down

0 comments on commit c4c1cb5

Please sign in to comment.