Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Scroll prover with Snarkify SDK #4

Merged
merged 27 commits into from
Aug 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
072efae
Snarkify SDK integration
Gigatron Jun 26, 2024
090585a
fix imports
Gigatron Jun 26, 2024
b9571ab
remove lib.rs
Gigatron Jun 26, 2024
ce7bd8e
Revert "remove lib.rs"
Gigatron Jun 26, 2024
4b945d5
Running version
Gigatron Jun 26, 2024
c3deb06
add README
Gigatron Jun 27, 2024
0c55a04
Add sample job
Gigatron Jun 27, 2024
d626d0e
Support deploying to Snarkify platform (CPU version)
Gigatron Jul 2, 2024
71bae81
feat(cusnark): integrate cusnark
jd-bartlett96 Jun 29, 2024
dacffa3
Update dockerfile for gpu build
Gigatron Jul 4, 2024
f6ed68c
build(halo2-proofs): pin halo2-proofs version (#2)
jd-bartlett96 Jul 4, 2024
eabe5ce
Fix dockerfile and add readme for docker build
Gigatron Jul 8, 2024
9173f73
Update Cargo.lock
Gigatron Jul 8, 2024
cf34ab4
Fix the problem that a consectuive run in the same docker fails
Gigatron Jul 8, 2024
55e8f31
Add instructions for deployment and create task
Gigatron Jul 8, 2024
f1fd976
Update snarkify-sdk and halo2_proofs version
Gigatron Jul 18, 2024
c0efac0
Remove config reinit
Gigatron Jul 26, 2024
9999b1e
Add lazily initialized thread local prover
Gigatron Jul 29, 2024
b697782
bump halo2_proofs version
jd-bartlett96 Jul 30, 2024
f5542e2
fix naming of threadlocal prover
Gigatron Jul 30, 2024
3245589
cargo fmt
Gigatron Jul 30, 2024
63806a3
Allow pulling snarkify private repo
Gigatron Aug 14, 2024
411e44b
Use a different github action to setup ssh
Gigatron Aug 14, 2024
844bc8b
Add key for cusnark
Gigatron Aug 14, 2024
d5a2b1d
Use pat token for private repos
Gigatron Aug 14, 2024
b5b7ce8
Skip cargo checks since it requries building cusnark which needs gpu …
Gigatron Aug 14, 2024
42121d6
address comments
Gigatron Aug 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 72 additions & 60 deletions .github/workflows/prover.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,63 +37,75 @@ jobs:
concurrent_skipping: 'same_content_newer'
paths_ignore: '["**/README.md"]'

fmt:
needs: [skip_check]
if: |
github.event.pull_request.draft == false &&
(github.event.action == 'ready_for_review' || needs.skip_check.outputs.should_skip != 'true')
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly-2023-12-03
components: rustfmt
- name: Cargo cache
uses: Swatinem/rust-cache@v2
with:
workspaces: "prover -> target"
- name: Cargo check
run: cargo check --all-features
- name: Cargo fmt
run: cargo fmt --all -- --check

clippy:
needs: [skip_check, fmt]
if: |
github.event.pull_request.draft == false &&
(github.event.action == 'ready_for_review' || needs.skip_check.outputs.should_skip != 'true')
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly-2023-12-03
components: clippy
- name: Cargo cache
uses: Swatinem/rust-cache@v2
with:
workspaces: "prover -> target"
- name: Run clippy
run: cargo clippy --all-features --all-targets -- -D warnings

compile:
needs: [skip_check, clippy]
if: |
github.event.pull_request.draft == false &&
(github.event.action == 'ready_for_review' || needs.skip_check.outputs.should_skip != 'true')
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly-2023-12-03
- name: Cache cargo
uses: Swatinem/rust-cache@v2
with:
workspaces: "prover -> target"
- name: Test
run: |
make prover
# fmt:
# needs: [skip_check]
# if: |
# github.event.pull_request.draft == false &&
# (github.event.action == 'ready_for_review' || needs.skip_check.outputs.should_skip != 'true')
# runs-on: ubuntu-latest
# timeout-minutes: 5
# steps:
# - uses: actions/checkout@v4
# - uses: dtolnay/rust-toolchain@master
# with:
# toolchain: nightly-2023-12-03
# components: rustfmt
# - name: Cargo cache
# uses: Swatinem/rust-cache@v2
# with:
# workspaces: "prover -> target"
# - name: Configure Git to use PAT for specific repositories
# run: |
# git config --global url."https://${{ secrets.PAT_TOKEN }}@github.com/snarkify/halo2-scroll.git".insteadOf "https://github.com/snarkify/halo2-scroll.git"
# git config --global url."https://${{ secrets.PAT_TOKEN }}@github.com/snarkify/cusnark.git".insteadOf "https://github.com/snarkify/cusnark.git"
# - name: Cargo check
# run: cargo check --all-features
# - name: Cargo fmt
# run: cargo fmt --all -- --check
#
# clippy:
# needs: [skip_check, fmt]
# if: |
# github.event.pull_request.draft == false &&
# (github.event.action == 'ready_for_review' || needs.skip_check.outputs.should_skip != 'true')
# runs-on: ubuntu-latest
# timeout-minutes: 30
# steps:
# - uses: actions/checkout@v4
# - uses: dtolnay/rust-toolchain@master
# with:
# toolchain: nightly-2023-12-03
# components: clippy
# - name: Cargo cache
# uses: Swatinem/rust-cache@v2
# with:
# workspaces: "prover -> target"
# - name: Configure Git to use PAT for specific repositories
# run: |
# git config --global url."https://${{ secrets.PAT_TOKEN }}@github.com/snarkify/halo2-scroll.git".insteadOf "https://github.com/snarkify/halo2-scroll.git"
# git config --global url."https://${{ secrets.PAT_TOKEN }}@github.com/snarkify/cusnark.git".insteadOf "https://github.com/snarkify/cusnark.git"
# - name: Run clippy
# run: cargo clippy --all-features --all-targets -- -D warnings
#
# compile:
# needs: [skip_check, clippy]
# if: |
# github.event.pull_request.draft == false &&
# (github.event.action == 'ready_for_review' || needs.skip_check.outputs.should_skip != 'true')
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - uses: dtolnay/rust-toolchain@master
# with:
# toolchain: nightly-2023-12-03
# - name: Cache cargo
# uses: Swatinem/rust-cache@v2
# with:
# workspaces: "prover -> target"
# - name: Configure Git to use PAT for specific repositories
# run: |
# git config --global url."https://${{ secrets.PAT_TOKEN }}@github.com/snarkify/halo2-scroll.git".insteadOf "https://github.com/snarkify/halo2-scroll.git"
# git config --global url."https://${{ secrets.PAT_TOKEN }}@github.com/snarkify/cusnark.git".insteadOf "https://github.com/snarkify/cusnark.git"
# - name: Test
# run: |
# make prover
Loading
Loading