Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add color variables from Figma and refactor #865

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Conversation

samuveth
Copy link
Contributor

@samuveth samuveth commented Feb 4, 2024

Summary

Add color variables from the design system on Figma.

Also fixes a small bug where the disabled button text color wasn't the correct one because of missing rgb().

This PR mostly adds the color variables, we will start using them all in future PRs

How to test

  1. Open two tabs with both versions to compare and click through the UI

@samuveth samuveth requested a review from Sekhmet February 4, 2024 11:22
@samuveth samuveth changed the title ref: Add color variables from figma and refactor ref: Add color variables from Figma and refactor Feb 4, 2024
@Sekhmet Sekhmet changed the title ref: Add color variables from Figma and refactor chore: Add color variables from Figma and refactor Feb 5, 2024
@Sekhmet
Copy link
Member

Sekhmet commented Feb 5, 2024

@samuveth can you link to Figma?

@samuveth
Copy link
Contributor Author

samuveth commented Feb 5, 2024

@Sekhmet
Copy link
Member

Sekhmet commented Feb 5, 2024

@samuveth I think we will have some changes to the naming (positive to success) etc. Do you think this should wait?

@samuveth
Copy link
Contributor Author

samuveth commented Feb 5, 2024

Yes, I will make those changes

@samuveth
Copy link
Contributor Author

samuveth commented Feb 5, 2024

Done

Copy link
Member

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@Sekhmet Sekhmet merged commit 09506d3 into master Feb 6, 2024
4 checks passed
@Sekhmet Sekhmet deleted the samuv/add-colors branch February 6, 2024 11:21
Sekhmet pushed a commit to snapshot-labs/sx-monorepo that referenced this pull request Feb 6, 2024
…ui#865)

* ref: Add color variables from figma and refactor

* Fix

* Fix

* ref: Change name to success
Sekhmet pushed a commit to snapshot-labs/sx-monorepo that referenced this pull request Feb 6, 2024
…ui#865)

* ref: Add color variables from figma and refactor

* Fix

* Fix

* ref: Change name to success

Signed-off-by: Wiktor Tkaczyński <wiktor.tkaczynski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants