-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add color variables from Figma and refactor #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@samuveth can you link to Figma? |
@samuveth I think we will have some changes to the naming (positive to success) etc. Do you think this should wait? |
Yes, I will make those changes |
Done |
Sekhmet
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Sekhmet
pushed a commit
to snapshot-labs/sx-monorepo
that referenced
this pull request
Feb 6, 2024
…ui#865) * ref: Add color variables from figma and refactor * Fix * Fix * ref: Change name to success
Sekhmet
pushed a commit
to snapshot-labs/sx-monorepo
that referenced
this pull request
Feb 6, 2024
…ui#865) * ref: Add color variables from figma and refactor * Fix * Fix * ref: Change name to success Signed-off-by: Wiktor Tkaczyński <wiktor.tkaczynski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add color variables from the design system on Figma.
Also fixes a small bug where the disabled button text color wasn't the correct one because of missing
rgb()
.This PR mostly adds the color variables, we will start using them all in future PRs
How to test