Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silero Package Init #127

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Silero Package Init #127

merged 3 commits into from
Feb 24, 2022

Conversation

Abhi011999
Copy link
Contributor

Review the changes, please.

TODO:

  1. Add tests.
  2. Re-factoring of both utility files (both files currently have redundant code).
  3. Add appropriate github action for auto publishing.

@Abhi011999
Migrated to standard python package template
31cef19 
Signed-off-by: Abhishek Dubey <abhi.dubey011999@gmail.com>
@Abhi011999
Removed redundant code
3287fc6 
Signed-off-by: Abhishek Dubey <abhi.dubey011999@gmail.com>
@Abhi011999
Minor change to hubconf.py
107e559 
Signed-off-by: Abhishek Dubey <abhi.dubey011999@gmail.com>
@Abhi011999 Abhi011999 mentioned this pull request Feb 22, 2022
Open
@snakers4
Copy link
Owner

Sorry for a delay
I have read your changes, I have only one comment, they are ok
But I need to spend some time testing after merging
I am a bit busy doing basic preparations for obvious reasons

@snakers4 snakers4 merged commit 315b4e5 into snakers4:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snakers4 snakers4 snakers4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abhi011999 @snakers4