Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit web support #3

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Add explicit web support #3

merged 4 commits into from
Sep 13, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Sep 12, 2023

This is a breaking change.

@notgull
Add explicit web support
4846012 
This is a breaking change.

Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Fix accidental blocking use
d53b5d4 
Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Fix WASM build again
f65c739 
Signed-off-by: John Nunley <dev@notgull.net>
@fogti
Copy link
Member

fogti commented Sep 12, 2023

ok, so now it complains about lack of wasm-bindgen in dev-dependencies or such...

@notgull
Use wasm-bindgen-test on web targets
7667110 
Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Copy link
Member Author

notgull commented Sep 13, 2023

ok, so now it complains about lack of wasm-bindgen in dev-dependencies or such...

I needed to use wasm-bindgen-test instead of regular test, fixed!

@notgull notgull merged commit 77f9bb8 into main Sep 13, 2023
@notgull notgull deleted the notgull/web branch September 13, 2023 15:32
@notgull notgull mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notgull @fogti @taiki-e