Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat monitor: Add some aliases #4872

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Chat monitor: Add some aliases #4872

merged 1 commit into from
Sep 25, 2018

Conversation

panpawn
Copy link
Contributor

@panpawn panpawn commented Sep 24, 2018

And change spacing of help command to match the rest

And change spacing of help command to match the rest
@@ -324,14 +324,20 @@ let commands = {
return this.sendReply(`'${words.join(', ')}' ${Chat.plural(words, "were", "was")} removed from the ${list} list.`);
}
},
'': 'view',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should maybe show help.

Or maybe the view page should show help?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to show the list here. /filters to me is: "what are the filters?" I think that's what they'd be for most people that do just that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, unless you're an admin, that's all you can do with them anyway.

But maybe the filter list should contain add/remove instructions, for admins.

@Zarel Zarel merged commit bd969af into smogon:master Sep 25, 2018
@Zarel
Copy link
Member

Zarel commented Sep 25, 2018

Merging, but I do still want help added to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants