-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add September RoA Spotlight, LCotM, and OMotM #4838
Conversation
// @ts-ignore | ||
set.sketchMove = move.id; | ||
return null; | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TI asked me about event-locked moves, but I was out that day, and my computer rebooted to install updates before I could remember to reply. Sorry about that.
Anyway, in answer to his question, I don't actually know whether sketching event-locked moves was ever supported, although I do know I had some interim code which basically went through each sketchable move temporarily deleting it from the set in the hope that it would validate without that move. I suspect that version would have worked with event-locked moves, but it was really ugly.
config/formats.js
Outdated
name: "[Gen 7] Benjamin Butterfree", | ||
desc: `Pokémon that faint reincarnate as their prevo, but without the moves they can't learn.`, | ||
name: "[Gen 7] Partners in Crime", | ||
desc: "Doubles-based metagame where both active ally Pokémon share abilities and moves.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong sort of quotes? (I really should update ROM some time...)
config/formats.js
Outdated
} | ||
}, | ||
onFaint: function (pokemon) { | ||
// this.add('-hint', 'checking ally ability after faint of ' + pokemon); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, looks like I have three lines of old debugging code that I need to delete...
Your Sketchmons bans are outdated btw @urkerab |
https://www.smogon.com/forums/threads/roa-communitys-choice-ladder-september-2018-oras-1v1.3640777/page-5#post-7894727