Refactor berries' events and Fix Emergency Exit's interactions with hazards and residuals #10902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dont use the TakeDamage handler work as intended
pyuk-bot
reviewed
Feb 13, 2025
urkerab
reviewed
Feb 13, 2025
…ix' into emergency-exit Refactored berry implementation helps resolve certain Emergency Exit bugs.
Merged
|
I tested both new tests on the console. To fix the new Intimidate test, we would need to separate the act of switching out from the act of switching in. |
There are too many checks 'switchFlag === true'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #8354
I merged the branch from that PR because the berry refactor helps fix some Emergency Exit bugs.
I confirmed that non-healing berries also activate after Anger Shell/Berserk (I tested Ganlon Berry Klawf).
This test is currently in draft because one test that was previously working is now failing (it is currently skipped in this PR).Ready for review!