fix: sigv4 now correctly trims spaces #799
Conversation
add: test for space trimming add: s3 signing integration test add: lambda signing integration test
|
A new generated diff is ready to view: __generated-main...__generated-signing-should-correctly-trim-spaces |
aws/sdk/integration-tests/lambda/tests/naughty-strings-client-context.rs
Outdated
Show resolved
Hide resolved
aws/rust-runtime/aws-sigv4/src/http_request/canonical_request.rs
Outdated
Show resolved
Hide resolved
|
A new generated diff is ready to view: __generated-main...__generated-signing-should-correctly-trim-spaces |
add: missing LICENSE for BLNS
|
A new generated diff is ready to view: __generated-main...__generated-signing-should-correctly-trim-spaces |
|
A new generated diff is ready to view: __generated-main...__generated-signing-should-correctly-trim-spaces |
|
A new generated diff is ready to view: __generated-main...__generated-signing-should-correctly-trim-spaces |
update: ignore naughty strings tests that require real aws connection fix: s3 naughty strings metadata signing test
|
A new generated diff is ready to view: __generated-main...__generated-signing-should-correctly-trim-spaces |
remove: circular dep aws-config from integration testing crates update: comment out tests not runnable by CI format: run cargo fmt
|
A new generated diff is ready to view: __generated-main...__generated-signing-should-correctly-trim-spaces |
update: hide lambda tests from integration runner
|
A new generated diff is ready to view: __generated-main...__generated-signing-should-correctly-trim-spaces |
|
A new generated diff is ready to view: __generated-main...__generated-signing-should-correctly-trim-spaces |
aws/rust-runtime/aws-sigv4/src/http_request/canonical_request.rs
Outdated
Show resolved
Hide resolved
aws/rust-runtime/aws-sigv4/src/http_request/canonical_request.rs
Outdated
Show resolved
Hide resolved
aws/sdk/integration-tests/lambda/tests/naughty-strings-client-context.rs
Show resolved
Hide resolved
add: proptest for trim_all update: convert trimming to work on byte slices instead of strings update: update trimming test to use byte slices
|
A new generated diff is ready to view: __generated-main...__generated-signing-should-correctly-trim-spaces |
1 similar comment
|
A new generated diff is ready to view: __generated-main...__generated-signing-should-correctly-trim-spaces |
update: test_trim_all_ignores_other_forms_of_whitespace to be more robust update: use indexes over iterators in an attempt to appease the optimizer update: test_s3_signer_with_naughty_string_metadata expected signature
|
A new generated diff is ready to view: __generated-main...__generated-signing-should-correctly-trim-spaces |
|
A new generated diff is ready to view: __generated-main...__generated-signing-should-correctly-trim-spaces |
|
A new generated diff is ready to view: __generated-main...__generated-signing-should-correctly-trim-spaces |
add: test for space trimming
add: s3 signing integration test
add: lambda signing integration test
Motivation and Context
This will fix awslabs/aws-sdk-rust#248 and close #761
Description
Our implementation of SigV4 signing didn't implement all required behavior. This PR implements that behavior and includes tests to ensure that it keeps working.
Testing
I have written tests for the new functions and an integration test to check that bug reported for S3 metadata is fixed.
Checklist
CHANGELOG.mdaws/SDK_CHANGELOG.mdif applicableBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.