Use Integer::div_floor explicitly
#694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-lang/rust#88581 adds several new integer methods as inherent impls. These new methods are a breaking change accepted as a minor change. They already cause build failures with nightly and will eventually cause build failures with stable as well, unless rust-lang changes course. This uses `Integer::div_floor` explicitly to avoid accidentally calling the new nightly methods, same as done for rust-num/num-bigint#218.
rcoh
reviewed
Sep 13, 2021
|
Fixes #700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
rust-lang/rust#88581 adds several new integer methods as inherent impls. These new methods are a breaking change accepted as a minor change. They already cause build failures with nightly and will eventually cause build failures with stable as well, unless rust-lang changes course.
Description
This uses
Integer::div_floorexplicitly to avoid accidentally calling the new nightly methods, same as done for rust-num/num-bigint#218.Testing
Tested
smithy-typeson stable, beta, and nightly using the following toolchains:Checklist
CHANGELOG.mdaws/SDK_CHANGELOG.mdif applicableI don't think updates to
aws/SDK_CHANGELOG.mdare applicable. I'm not sure if this merits updates toCHANGELOG.mdeither; please let me know if it does.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.