Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default HTTPS stack based on platform support #3985

Draft
wants to merge 3 commits into
base: hyper1
Choose a base branch
from
Draft

Conversation

aajtodd
Copy link
Contributor

@aajtodd aajtodd commented Jan 24, 2025

Motivation and Context

Description

Modifies the default TLS provider based on platform support and changes the default for unix to s2n-tls.

I had to introduce a new crate aws-smithy-default-tls to make this work. This is because we can't modify dependencies or add new features based on a feature. Doing it without a new crate seems only possible with rust-lang/cargo#1197.

The way around this is to consider the crate itself a "feature" and then we can make use of rust-lang/cargo#7914 which allow specifying features on a dependency predicated on target.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant