Python: Event Streaming #2482
Merged
Python: Event Streaming #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
7498599 to
b610cb2
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
21209b9 to
b7afb23
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
b7afb23 to
86b681f
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
unexge
commented
Mar 31, 2023
codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/rustlang/RustType.kt
Show resolved
Hide resolved
| } | ||
|
|
||
| companion object { | ||
| data class EventStreamSymbol(val innerT: RustType, val errorT: RustType) |
There was a problem hiding this comment.
Let's discuss about this approach
...tlin/software/amazon/smithy/rust/codegen/server/python/smithy/PythonServerCargoDependency.kt
Outdated
Show resolved
Hide resolved
| private val pyO3Asyncio = PythonServerCargoDependency.PyO3Asyncio.toType() | ||
| private val tokio = PythonServerCargoDependency.Tokio.toType() | ||
| private val futures = PythonServerCargoDependency.Futures.toType() | ||
| private val parkingLot = PythonServerCargoDependency.ParkingLot.toType() |
There was a problem hiding this comment.
Let's create an issue to whether we can switch to std::sync::Mutex instead of parking_lot::Mutex
...ithy/rust/codegen/server/python/smithy/generators/PythonServerEventStreamWrapperGenerator.kt
Outdated
Show resolved
Hide resolved
...ithy/rust/codegen/server/python/smithy/generators/PythonServerEventStreamWrapperGenerator.kt
Show resolved
Hide resolved
86b681f to
c8ee180
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
approved these changes
Apr 10, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Add `RustType.Application` and `PythonType.Application` variants * Use `RustType.Application` for event streaming symbols * Call symbol provider to get `Receiver` type instead of hardcoding * Add Python specific event streaming symbol provider * Add event streaming wrapper generator * Generate correct type information for event streaming types * Add `CapturePokemon` operation to Python Pokemon service * Add `InternalServerError` variant to all event streaming errors * Use `PythonServerCargoDependency` for PyO3Asyncio imports * Return an attribute error instead of panicking in `IntoPy` impls of wrappers * Add `Sync` bound to `new` methods of wrappers * Revert "Add `InternalServerError` variant to all event streaming errors" This reverts commit b610cb2. * Add `PythonServerEventStreamErrorGenerator` to generate Python specific error types for unions * Try to extract error type or inner type from incoming streaming value and ignore the value otherwise for now * Allow missing type-stubs for `aiohttp` * Propogate modelled errors through stream * Raise modelled exceptions rather than sending through stream * Allow senders from Python side to raise modelled exceptions * Update `EventStreamSymbolProviderTest` to use `Application` type instead of `Opaque` type * Fix `ktlint` issues * Group up common variables in `codegenScope` * Document `RustType.Application` * Format `codegen-server-test/python/model/pokemon.smithy` * Use `tokio-stream` crate instead of `futures` crate * Use a better error message if user tries to reuse a stream * Add some details about event streams to example Pokemon service --------- Co-authored-by: Matteo Bigoi <1781140+crisidev@users.noreply.github.com>
unexge
added a commit
that referenced
this pull request
Apr 24, 2023
* Add `RustType.Application` and `PythonType.Application` variants * Use `RustType.Application` for event streaming symbols * Call symbol provider to get `Receiver` type instead of hardcoding * Add Python specific event streaming symbol provider * Add event streaming wrapper generator * Generate correct type information for event streaming types * Add `CapturePokemon` operation to Python Pokemon service * Add `InternalServerError` variant to all event streaming errors * Use `PythonServerCargoDependency` for PyO3Asyncio imports * Return an attribute error instead of panicking in `IntoPy` impls of wrappers * Add `Sync` bound to `new` methods of wrappers * Revert "Add `InternalServerError` variant to all event streaming errors" This reverts commit b610cb2. * Add `PythonServerEventStreamErrorGenerator` to generate Python specific error types for unions * Try to extract error type or inner type from incoming streaming value and ignore the value otherwise for now * Allow missing type-stubs for `aiohttp` * Propogate modelled errors through stream * Raise modelled exceptions rather than sending through stream * Allow senders from Python side to raise modelled exceptions * Update `EventStreamSymbolProviderTest` to use `Application` type instead of `Opaque` type * Fix `ktlint` issues * Group up common variables in `codegenScope` * Document `RustType.Application` * Format `codegen-server-test/python/model/pokemon.smithy` * Use `tokio-stream` crate instead of `futures` crate * Use a better error message if user tries to reuse a stream * Add some details about event streams to example Pokemon service --------- Co-authored-by: Matteo Bigoi <1781140+crisidev@users.noreply.github.com>
rcoh
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Add `RustType.Application` and `PythonType.Application` variants * Use `RustType.Application` for event streaming symbols * Call symbol provider to get `Receiver` type instead of hardcoding * Add Python specific event streaming symbol provider * Add event streaming wrapper generator * Generate correct type information for event streaming types * Add `CapturePokemon` operation to Python Pokemon service * Add `InternalServerError` variant to all event streaming errors * Use `PythonServerCargoDependency` for PyO3Asyncio imports * Return an attribute error instead of panicking in `IntoPy` impls of wrappers * Add `Sync` bound to `new` methods of wrappers * Revert "Add `InternalServerError` variant to all event streaming errors" This reverts commit b610cb2. * Add `PythonServerEventStreamErrorGenerator` to generate Python specific error types for unions * Try to extract error type or inner type from incoming streaming value and ignore the value otherwise for now * Allow missing type-stubs for `aiohttp` * Propogate modelled errors through stream * Raise modelled exceptions rather than sending through stream * Allow senders from Python side to raise modelled exceptions * Update `EventStreamSymbolProviderTest` to use `Application` type instead of `Opaque` type * Fix `ktlint` issues * Group up common variables in `codegenScope` * Document `RustType.Application` * Format `codegen-server-test/python/model/pokemon.smithy` * Use `tokio-stream` crate instead of `futures` crate * Use a better error message if user tries to reuse a stream * Add some details about event streams to example Pokemon service --------- Co-authored-by: Matteo Bigoi <1781140+crisidev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #1752
Description
Testing
TODOs
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.