Client response streaming minimum speed limit/timeout #1562
Assignees
Labels
Comments
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 26, 2023
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> #1562 ## Description <!--- Describe your changes in detail --> This change adds a new body wrapper: The minimum throughput limit wrapper. It tracks the rate that data is being streamed from itself. If that rate falls below some configurable limit, it emits an error instead of the next chunk. This protects users from requests that start quickly but then slow down considerably. I'd like to get this merged and then figure out the codegen/docs/examples/config part in a separate PR. ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> Tests are included. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 17, 2023
[See the upgrade guide for this feature to learn more.](awslabs/aws-sdk-rust#956) The breaking change is to the `MinimumThroughputBody::new` method. ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> #1562 ## Description <!--- Describe your changes in detail --> awslabs/aws-sdk-rust#956 ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> I added several tests ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: John DiSanti <jdisanti@amazon.com> Co-authored-by: Russell Cohen <rcoh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clients should have a way of timing out if the response stream started but then slowed significantly or stopped entirely without closing the connection part way through. For example, if a call to S3 GetObject was made, and some bytes of the object were received in the streaming response body, but the server stopped responding with more for a significant period of time, that should result in a timeout.
Internal tracking: P66130286
The text was updated successfully, but these errors were encountered: