Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding GHP Rejects Un-Scoped NPM 📦 (#93) #98

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

mblomdahl
Copy link
Member

🚀 Description

After merging #94, we find that GitHub Packages [GHP], does not accept publishing of un-scoped packages. Instead of giving up on GHP entirely, let's publish this under two different names:

  1. On NPM, as always, it's the mapbox-gl-circle package
  2. On GHP, it's the same code as on NPM but published as the "@smithmicro/mapbox-gl-circle" package

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

After merging smithmicro#94, we find that GitHub Packages \[GHP\], does not accept publishing of un-scoped packages. Instead of giving up on GHP entirely, let's publish this under two different names:
1. On NPM, as always, it's the `mapbox-gl-circle` package
2. On GHP, it's the same code as on NPM but published as the "`@smithmicro/mapbox-gl-circle`" package
@mblomdahl mblomdahl added the bug label Oct 23, 2022
@mblomdahl mblomdahl self-assigned this Oct 23, 2022
@mblomdahl mblomdahl merged commit 880898d into smithmicro:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant