Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache class fails to resolve typescript module correctly when source files are in a subdirectory #36

Closed
smhxx opened this issue Mar 26, 2018 · 0 comments
Closed

Cache class fails to resolve typescript module correctly when source files are in a subdirectory #36

smhxx opened this issue Mar 26, 2018 · 0 comments
Assignees
@smhxx
Labels
Type: Bug Report Urgency: Apocalyptic

Comments

@smhxx
Copy link
Owner

smhxx commented Mar 26, 2018 •
edited
Loading

Related issues (if any): crystal-lang-tools/atom-ide-crystal#31
Type of issue: 🐛Bug Report
Urgency: 💥Apocalyptic

A regression was introduced in v1.5.0 which causes the Cache class to fail to resolve the typescript peer dependency when transpiling source files that are not on the package root directory. Because the only source file in the integration test fixture is located on the package root directory, this regression was not caught by the normal integration testing. v1.5.0 has been unpublished until this bug is resolved.

Steps to fix:

  • Fix the Cache class to properly determine the location of the node_modules directory when the source file being transpiled is in a subdirectory
  • Add unit testing for the case where the file is not at the package root (these tests previously existed in spec/unit/Transpiler-spec.ts but were deleted when src/Transpiler.ts was refactored away.
  • Update integration test fixture to ensure that transpilation works for source files located in subdirectories

v1.5.0 will be republished when this issue is resolved.
@smhxx smhxx self-assigned this Mar 26, 2018
@smhxx smhxx closed this as completed in af3cd0d Mar 27, 2018
smhxx pushed a commit that referenced this issue Mar 27, 2018
@semantic-release-bot
chore(release): 1.5.0 [skip ci]
2bfefeb 
<a name="1.5.0"></a>
# [1.5.0](v1.4.3...v1.5.0) (2018-03-27)

### Bug Fixes

* fix critical issue introduced in previously published v1.5.0 ([af3cd0d](af3cd0d)), closes [#36](#36)

### Features

* **getCacheKeyData:** include TypeScript module version in cacheKeyData ([93d6538](93d6538))
smhxx pushed a commit that referenced this issue Mar 27, 2018
@semantic-release-bot
chore(release): 1.5.1 [skip ci]
acd70dc 
<a name="1.5.1"></a>
## [1.5.1](v1.5.0...v1.5.1) (2018-03-27)

### Bug Fixes

* fix critical issue introduced in previously published v1.5.0 ([af3cd0d](af3cd0d)), closes [#36](#36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smhxx smhxx

Labels
Type: Bug Report Urgency: Apocalyptic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smhxx