add county_source to the sdk #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ducanbeu
reviewed
Nov 11, 2024
| @@ -8,7 +8,8 @@ const Lookup = SmartySDK.usStreet.Lookup; | |||
| // const credentials = new SmartyCore.StaticCredentials(authId, authToken); | |||
|
|
|||
| // for client-side requests (browser/mobile), use this code: | |||
| let key = process.env.SMARTY_EMBEDDED_KEY; | |||
There was a problem hiding this comment.
I think that it's important we keep this line as it adds context to the comment above. Maybe there could be a comment added after, such as... let key = process.env.SMARTY_EMBEDDED_KEY // "your key".
Also, is there any reason we couldn't freshen this up by changing let -> const? I don't think this variable needs to be mutable, does it?
| batch.add(lookup2); | ||
| batch.add(lookup3); | ||
|
|
||
| await handleResponse(batch); |
There was a problem hiding this comment.
Just out of curiosity... Is there a reason why we don't want to showcase batching in the example anymore?
|
@ducanbeu |
ducanbeu
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClickUp: https://app.clickup.com/t/86b2rzryh
you may need to run
npm run buildto build the code before testing.I added an example address to the example file. To test, run the us_street example and see that the output for
county_nameis Johnson and thecounty_fipsis 48251.If you uncomment line 33 in the example, enabling geographic county source, you'll see the output for
county_namechange to Tarrant andcounty_fipschange to 48439Once this is approved I'll revert the changes to
examples/us_street.js