Merge pull request #377 from a-shpota/fix-writefile-sysplugin

fix 'mkdir(): File exists' error on create directory from parallel processes
smarty-php · Jul 21, 2017 · ba2de97 · ba2de97
2 parents 67e9d08 + 6768340
commit ba2de97
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/libs/sysplugins/smarty_internal_runtime_writefile.php b/libs/sysplugins/smarty_internal_runtime_writefile.php
@@ -37,9 +37,11 @@ public function writeFile($_filepath, $_contents, Smarty $smarty)
         }
 
         $_dirpath = dirname($_filepath);
-        // if subdirs, create dir structure
-        if ($_dirpath !== '.' && !file_exists($_dirpath)) {
-            mkdir($_dirpath, $_dir_perms, true);
+
+       // if subdirs, create dir structure
+        if ($_dirpath !== '.' && !@mkdir($_dirpath, $_dir_perms, true) && !is_dir($_dirpath)) {
+            error_reporting($_error_reporting);
+            throw new SmartyException("unable to create directory {$_dirpath}");
         }
 
         // write to tmp file, then move to overt file lock race condition