Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/security vulnerabilities #457

Merged
merged 4 commits into from
Jun 10, 2021
Merged

Conversation

crokita
Copy link
Contributor

@crokita crokita commented Jun 8, 2021

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have verified that this PR passes lint validation
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Summary

Resolve package vulnerabilities reported by Github and npm. Includes a major version change of express-ws and cleaning up the package-lock json files in the root and lib/node directories.

@crokita
Copy link
Contributor Author

crokita commented Jun 9, 2021

Ready for review. Note that the remaining reported packages cannot be resolved due to our webpack dependency for building the third party BSON library. We would have to either update webpack as a major version change, or replace it entirely with another bundler such as rollup. I have attempted both and the process is too complicated to do in short notice.

@crokita crokita merged commit 9bb5975 into develop Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants