Fix for Two voiceCommands contains the same string #1681
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1677
This PR is [ready] for review.
Risk
This PR makes [no] API changes.
Testing Plan
Unit Tests
Unit test were added in
VoiceCommandManagerTests
Core Tests
Try to upload two different voice commands with the same strings, observe error messages in logs, and voice commands do not upload.
Error message:
Not all voice command strings are unique across all voice commands. Voice commands will not be set.
Also, verify that uploading voice commands work normally with each command having a unique string.
Core version / branch / commit hash / module tested against: 7.1.0 and Sync 3
HMI name / version / branch / commit hash / module tested against: generic_hmi 0.10.0, sdl_hmi 5.5.1
Summary
Added capability to
VoiceCommandManager
to check to make sure all voice commands are unique. If voice commands are not unique, it will print out an error message to the logs and return.Changelog
Bug Fixes
VoiceCommandManager
to check to make sure all voice commands are unique. If voice commands are not unique, it will print out an error message to the logs and return.CLA