Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samsung devices not properly managing notification channels #1351

Closed
joeygrover opened this issue May 15, 2020 · 0 comments · Fixed by #1360
Closed

Samsung devices not properly managing notification channels #1351

joeygrover opened this issue May 15, 2020 · 0 comments · Fixed by #1360
Labels
bug A defect in the library router-service Relating to the router service

Comments

@joeygrover
Copy link
Member

joeygrover commented May 15, 2020

Bug Report

Since the channel delete code as added back in last release to address some phones not clearing the notification, a new issue has appeared with Samsung devices. These devices are not properly deleting and recreating the notification channel and therefore it throws a fatal exception. While the code itself in the library should not allow this to happen, it seems the OS has other issues.

Reproduction Steps
  1. Star SDL connection like normal
  2. Disconnect
  3. Restart SDL connection, should crash
Expected Behavior

Notification is displayed and clears properly.

Observed Behavior

Notification is not created, RS not started, app experiences fatal crash

Fatal Exception: android.app.RemoteServiceException
Bad notification for startForeground: java.lang.RuntimeException: invalid channel for service notification: Notification(channel=sdl_notification_channel pri=0 contentView=null vibrate=null sound=null tick defaults=0x0 flags=0x40 color=0x00000000 vis=PRIVATE semFlags=0x0 semPriority=0 semMissedCount=0)
OS & Version Information
  • Assuming Android 9+, likely 10
    *Devices: Samsung S10+, Note 10+, S10, S9+, S9,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library router-service Relating to the router service
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants