-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch sending of RPC Requests #857
Batch sending of RPC Requests #857
Conversation
* SDLAsynchronousRPCRequestOperation handles single RPC requests as well * Fix name of SDLAsynchronousRPCRequestOperation * SDLConnectionManagerType now can send a “regular”/“non-manager” RPC request * Add RPC Operation queue to the lifecycle manager
d0dd243
to
e25821e
Compare
* Many sequential RPC sending updates * Tests
# Conflicts: # SmartDeviceLink/SDLLifecycleManager.m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with Livio Music player and Core 4.4.1. Sending multipleCreateInteractionChoiceSet
s and SubscribeButton
s sequentially and simultaneously worked correctly.
Known issue: On both SYNC 3 and Manticore, sending multiple requests simultaneously usually failed after first 2-5.
What do you mean by "sending multiple requests simultaneously"? And does it recover? |
To test this PR, I sent 13 This error has been reported to the Manticore team. Due to more pressing issues, they will not be able to investigate immediately. |
Fixes #723
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit tests will be added
Summary
Add support for batch sending RPCs sequentially. Either one right after another, or waiting for the last to return before sending the next.
Changelog
Enhancements
Tasks Remaining:
SDLLifecycleManager
CLA