v5.1 Release #842

joeljfischer · 2018-01-10T14:02:30Z

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Tests have been added

Summary

This is the v5.1 release focusing on CarWindow automatic view-based streaming and audio stream enhancements.

Changelog

Enhancements

Log unsuccessful RPC responses automatically. (Log unsuccessful RPC responses automatically #811)
IAP Transport reconnection optimizations. (SDLIAPTransport Does Not Reconnect Successfully #816)
Adds SDLAudioStreamManager that does on-the-fly transcoding of audio files to an SDL compatible PCM format and can send that audio to be played. This is for NAVIGATION applications only. [SDL-0113] ([SDL 0113] SDLAudioStreamManager #795)
CarWindow automated ViewController based streaming [SDL-0111] ([SDL 0111] SDLCarWindow #794)
- Add automatic video streaming via screenshotting.
- Update the Lock Screen to use a UIWindow on top of any other UI.
- SDLStreamingMediaManager now manages framerate more strictly using a CADisplayLink and uses this to sync touch manager and car window updates to the framerate.
- Several SDLStreamingMediaConfiguration changes to support CarWindow.
- Update SDLTouchManager to sync callbacks with the framerate, this fixes many issues with drawing at inopportune times. There is a BOOL to retain old behavior.

Bug Fixes

Enabled additional Xcode 9 warnings when building the project and fixed many warnings, mainly around implicit casts. (Enable additional Xcode 9 warnings #814)
Fix SDLSlider initializer infinite recursion. (SDLSlider initializer has infinite recursion #808)
Fix crash if disconnected while setting up the app icon. (Crash if disconnected while setting up app icon #833)
Force manual IAP session stop calls to run on the main queue. (Force IAPSession assert on main queue #831)
Navigation audio stream is no longer viewed as available in HMI NONE. (Audio stream is not stopped at hmi level none and background #803)

Other

Remove an unused testing library from the Cartfile. (Remove the unused OHHTTPStubs library from project #823)

Tasks Remaining:

Testing

CLA

I have signed the CLA

- only given three tries to create both a control and a data session - the retry counter is now only reset when an accessory is disconnected during a control or data session - ProtocolIndexTimeoutSeconds reduced from 20 to 10 seconds

* Integrated CarWindow into existing SMM

* Add mock and spec classes for testing the audio manager * Add a public domain MP3 cut down to a short length for audio manager testing

* Exposed AudioStreamManager error codes publicly * Additional tests

* Return more accurate file url in delegate * Add to public files

* Fix setting background color of lock screen

…n_assert Force `stop` to run on the main thread

* Lock screen screenshot was not being captured, it is now captured prior to presentation

CarWindow - Automatic Video Streaming

…disconnect_crash Fix crash when disconnecting while setting up app icon

* When app window isn’t in the expected place in the array, iterate through it instead

…ow_present Fix #838 Lock screen presenter

# Conflicts: # SmartDeviceLink/SDLTCPTransport.m

…t_streaming_on_reconnects Fixed car window not streaming video on reconnects

NicoleYarroch and others added 30 commits October 19, 2017 16:05

Fixed infinite iAP transport connects

ed1c722

- only given three tries to create both a control and a data session - the retry counter is now only reset when an accessory is disconnected during a control or data session - ProtocolIndexTimeoutSeconds reduced from 20 to 10 seconds

Merge branch 'master' into develop

22db5e7

Starting work on CarWindow

d3b7ed5

Change to using a lock window

dd6c403

Move the lock screen out of the CarWindow

91eed5d

Merge branch 'master' into develop

ec50146

Fix analyzer errors

a4a7d12

Add a few more streaming configuration initializers

978e93b

Fixed several bugs with new lock screen presenter

315e741

* Integrated CarWindow into existing SMM

Fix a slip of the keyboard

0b1b193

Remove a log

1610543

Fix existing tests

26f7dea

Minor updates

9d0a6b7

Add documentation and logging

1e1244e

Initial work on AudioStreamingManager

5c389fa

Fix analyzer errors

c5f6fd8

Update Swift usage

631d634

Applying Amazon optimizations

c762c81

Create an audio streaming protocol for testing

1a41aaf

* Add mock and spec classes for testing the audio manager * Add a public domain MP3 cut down to a short length for audio manager testing

Fix attempting to send data when not connected

79fbab3

Fix a bug that could cause slightly cut off audio

2d25102

* Exposed AudioStreamManager error codes publicly * Additional tests

Update tests

ce00251

* Return more accurate file url in delegate * Add to public files

Merge branch 'master' into develop

81c0ae2

Merge branch 'develop' into feature/issue_795_AudioStreamingManager

1e8453b

Fix an issue with importing

ac473d8

Fix location of some files causing public files to not be found

4953a5d

Integrate the audio manager with the streaming media manager

bd30155

Fix SDLSlider to properly initialize a static footer

ba04e9a

Update SDLSlider documentation

b931243

SDLManager hmiLevel should be nullable

8b58fb7

joeljfischer added 23 commits January 2, 2018 15:42

Fix setting a new rootViewController

0d9db30

* Fix setting background color of lock screen

Up the max data rate limit / 5 second

d64b570

Remove hard data limit

994b559

Fix error when allocating a pixel buffer

b7704e0

Fix lock screen

4720668

Add documentation to SDLCarWindowViewController

8b6d8dd

Default to layer rendering with an option for view rendering

b2085b9

Rest of last commit

9340617

Fix error

9ffc411

Fix testcase

07d7163

Fix focussed test

5f8d711

Merge pull request #832 from smartdevicelink/bugs/issue_831_iapsessio…

b7c427d

…n_assert Force `stop` to run on the main thread

Merge branch 'develop' into feature/issue_794_CarWindow

a03434f

Simplify some CarWindow configuration

2920d9a

Don’t resize the CarWindow rootVC in setRootVC if we are not streaming

eccf8e7

Fix presenting lock screen

e3bc79d

* Lock screen screenshot was not being captured, it is now captured prior to presentation

Merge pull request #799 from smartdevicelink/feature/issue_794_CarWindow

6432ecb

CarWindow - Automatic Video Streaming

Merge branch 'develop' into bugs/issue_833_app_icon_disconnect_crash

e1755ca

Merge pull request #834 from smartdevicelink/bugs/issue_833_app_icon_…

273698b

…disconnect_crash Fix crash when disconnecting while setting up app icon

Fix #838 Lock screen presenter

07a362b

* When app window isn’t in the expected place in the array, iterate through it instead

Merge pull request #839 from smartdevicelink/bugs/issue_838_lock_wind…

3cdbf27

…ow_present Fix #838 Lock screen presenter

Fix implicit retains of self

9459f8c

Merge branch 'bugs/issue_840_fix_implicit_retains' into develop

0af113b

joeljfischer added the epic label Jan 10, 2018

joeljfischer added this to the 5.1.0 milestone Jan 10, 2018

joeljfischer and others added 4 commits January 10, 2018 09:03

Merge branch 'master' into develop

4c67625

# Conflicts: # SmartDeviceLink/SDLTCPTransport.m

Added a return so a notification is not sent if no lockscreen is present

5042a2d

Merge pull request #844 from smartdevicelink/bugfix/843_car_window_no…

302b0b4

…t_streaming_on_reconnects Fixed car window not streaming video on reconnects

Remove unneeded haptic rect test

6654e3b

joeljfischer merged commit 345121a into master Jan 16, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v5.1 Release #842

v5.1 Release #842

joeljfischer commented Jan 10, 2018 •

edited

Loading

v5.1 Release #842

v5.1 Release #842

Conversation

joeljfischer commented Jan 10, 2018 • edited Loading

Risk

Testing Plan

Summary

Changelog

Enhancements

Bug Fixes

Other

Tasks Remaining:

CLA

joeljfischer commented Jan 10, 2018 •

edited

Loading