WIP: Issue 749 app crashes when usb cord is pulled #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added protection statements to prevent calls to delegate if nil Signed-off-by: NicoleYarroch <nicole@livio.io>
- fixed crash caused by strong reference cycle Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
- life cycle state machine was not taking into account that the accessory could be disconnected after the app icon was setup but before the hmi was setup Signed-off-by: NicoleYarroch <nicole@livio.io>
Codecov Report
@@ Coverage Diff @@
## release/5.0.0 #752 +/- ##
===============================================
Coverage ? 54.3%
===============================================
Files ? 318
Lines ? 7316
Branches ? 668
===============================================
Hits ? 3973
Misses ? 3101
Partials ? 242 |
Signed-off-by: NicoleYarroch <nicole@livio.io>
…_pulled Signed-off-by: NicoleYarroch <nicole@livio.io> # Conflicts: # SmartDeviceLink/SDLLifecycleManager.m
Signed-off-by: NicoleYarroch <nicole@livio.io>
|
@NicoleYarroch The IAPTransport notifications were being unsubscribed correctly. You should not have to do each individually. |
joeljfischer
suggested changes
Sep 29, 2017
| // We are sure to have a HMIStatus, set state to ready | ||
| [self.lifecycleStateMachine transitionToState:SDLLifecycleStateReady]; | ||
| } | ||
|
|
||
| - (void)didEnterStateReady { | ||
| if ([self sdl_didAccessoryDisconnect]) { |
There was a problem hiding this comment.
Are we certain having these everywhere is necessary? We are getting a transport disconnect notification (transportDidDisconnect) if the accessory disconnected.
|
This was closed due to targeting a deleted branch. If this still needs to exist, re-open against master or develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #749
Fixes #679
This PR is not ready for review.
Risk
This PR makes no API changes.
Testing Plan
None written yet
Summary
SDLIAPTransportclass, causing the app to crash when the USB cord was pulled.Changelog
Tasks Remaining:
CLA