Updated SDLTouchManager to support gesture cancellation #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
- Added test cases for onTouchEvent CANCEL Signed-off-by: NicoleYarroch <nicole@livio.io>
- Test cases written for single tap, double tap, and pan gesture cancellation Signed-off-by: NicoleYarroch <nicole@livio.io>
- got rid of unnecessary repeated code Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #673
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Test cases were added to the
SDLTouchManagerSpecclass to test canceling tap, pan, and pinch gestures.Summary
Adds support for detecting a
SDLTouchTypeof typeCANCEL. TheSDLTouchManagerhandles parsing theSDLOnTouchTypenotification from Core and issues a cancel delegate callback for pinch and pan gestures. If a single or double tap gesture is canceled, the tap is simply canceled.Changelog
Enhancements
SDLTouchTypeof typeCANCELin theSDLTouchManagerclass.SDLTouchManagerDelegate:touchManager:manager pinchCanceledAtCenterPoint:pointtouchManager:manager panningCanceledAtPoint:point.Bug Fixes
SDLRectangle.hto both of the.podspecfiles.CLA