Bugfix/control frame payload init crash #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeljfischer
suggested changes
Aug 29, 2017
| __block NSData *testData = nil; | ||
|
|
||
| beforeEach(^{ | ||
|
|
There was a problem hiding this comment.
Unneeded blank line on these tests
joeljfischer
approved these changes
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #715
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
added in unit test methods to test initialization with nil data
Summary
Modifying the if statement from
if (data != nil) {}toif (data.length > 0) {}fixed the issue. This change was made to all the classes with that method in the Control Frame Payloads folderCLA