Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SDL 0078 and SDL 0052 Control Frame Payloads #669

Merged
merged 27 commits into from
Aug 15, 2017
Merged

Implement SDL 0078 and SDL 0052 Control Frame Payloads #669

merged 27 commits into from
Aug 15, 2017

Conversation

joeljfischer
Copy link
Contributor

@joeljfischer joeljfischer commented Jul 27, 2017 •
edited
Loading

Fixes #663, #616

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Unit tests and smoke tests will be conducted

Summary

Implements SDL-0052 and SDL-0078.

This PR implements constructed payloads, and building on top of that, control frame payloads. This involves several components:

  • Implement the bson_c_lib as a submodule
  • Build objects around the bson lib for the current implementation of control frame payloads
  • Send correct payloads in the protocol layer and decode correct payloads
  • Implement dynamic MTU sizing from start service ACKs

Changelog

Enhancements
  • Implement control frame payloads
  • Dynamic MTUs are now supported

Tasks Remaining:

  • Implement payload information around the video service ACK data (video width, height, protocol, and codec)
  • Implement enums from the Video Capabilities PR once implemented (video protocol / codec)
  • Block devs from using SMM for anything other than H.264 RAW.

Unit Tests

  • Implement unit test updates to protocol layer
  • Unit test dynamic MTU logic
  • Unit test control frame payload objects
  • Unit test video service payloads

CLA

@joeljfischer
Add bson library directly for now
9fdd18c
@joeljfischer
First pass at start service control message
67e5b14
@joeljfischer
Change what BSON payload objects are
f03bee5 
* Allow max MTU size to be manually set to account for protocol v5 variable MTU sizes

* Create a control frame payload type instead of control frame types
@joeljfischer
Add RPCStartServiceNak payload object
0b9f03c 
* Add Int32 and Int64 not found BSON constants
* Rename constants
* Allow most params to be nullable, put nullability checks in
* Create missing initializers
@joeljfischer
Change globals protocol version to be a string
075ece6 
* Old integer protocol version is now `majorProtocolVersion`
@joeljfischer
Protocol level integration of constructed payloads for RPC service
e10c511 
* New Protocol Listener delegates that pass the full protocol message
* Integrate protocol level constructed payloads for RPC start service, start service ACK, and start service NAK
@joeljfischer
* SDLControlFramePayloadRPCStartService now can be init with a string…
45646e9 
… directly

* SDLGlobals maxProxyProtocolVersion renamed
* Assemble and attach the protocol version to the RPCStartService control message
@joeljfischer
Create new files for new control frame payloads
c733d3f 
* Shift around files in some groups
@joeljfischer
Fix the protocol router not passing to the correct delegate methods
05d85f0
@joeljfischer
Fix start service not assembling a proper payload
4873336 
* Add a description to the start service payload
@joeljfischer
Add a descriptions to various control service payloads
ca2aa3d
@joeljfischer
Fix the protocol message router not properly passing messages
b651a9e
@joeljfischer
Add documentation to control frame payload types
5dd7c58 
* Fix a bug in the start service ack v5 payload preventing the protocol version from being parsed
* Add the Video service start service and start service ack payload objects
@joeljfischer
Update backing bson library
cc70dd1
@joeljfischer
Move custom initializer back to default
97b80ac
@joeljfischer
Fix service payload data size not being set
bc8e676
@joeljfischer
Implemented dynamic MTU per service
22a8682
@joeljfischer
Update to use bson library submodule
589ff02
@joeljfischer joeljfischer added enhancement proposal Accepted SDL Evolution Proposal labels Jul 27, 2017
@joeljfischer joeljfischer added this to the 4.7.0 milestone Jul 27, 2017
@joeljfischer joeljfischer self-assigned this Jul 27, 2017
@joeljfischer joeljfischer changed the base branch from master to develop July 27, 2017 20:16
@joeljfischer joeljfischer mentioned this pull request Jul 27, 2017
Merged
3 tasks
@joeljfischer joeljfischer changed the title WIP: Control Frame Payloads WIP: Implement SDL 0078 and SDL 0052 Control Frame Payloads Jul 27, 2017
@joeljfischer
Update Streaming Media Manager with video control payloads
08e0cd3
@joeljfischer
Add tests for video start service payloads
f0a1ef1 
* Fix a bug in video start service ack payload
* Remove unused hash id parameter in audio start service ack payload spec
@joeljfischer joeljfischer changed the title WIP: Implement SDL 0078 and SDL 0052 Control Frame Payloads Implement SDL 0078 and SDL 0052 Control Frame Payloads Aug 9, 2017
@joeljfischer joeljfischer merged commit 79f4340 into develop Aug 15, 2017
@joeljfischer joeljfischer deleted the feature/616_constructed_payloads branch August 15, 2017 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrettyWhite BrettyWhite BrettyWhite approved these changes

Assignees

@joeljfischer joeljfischer

Labels
proposal Accepted SDL Evolution Proposal
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joeljfischer @BrettyWhite