[SDL-0005] Immutable RPC collections #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 9.95% (diff: 10.52%)
|
asm09fsu
reviewed
Jan 20, 2017
asm09fsu
reviewed
Jan 20, 2017
| NSMutableArray *newList = [NSMutableArray arrayWithCapacity:[array count]]; | ||
| for (NSDictionary<NSString *, id> *dict in array) { | ||
| [newList addObject:[[classType alloc] initWithDictionary:dict]]; | ||
| } | ||
| return newList; | ||
| return [NSArray arrayWithArray:newList]; |
There was a problem hiding this comment.
You can just do [newList copy]; instead because copy makes immutable properties.
asm09fsu
reviewed
Jan 20, 2017
| } | ||
| return newList; | ||
| } | ||
| - (NSArray<SDLEnum> *)sdl_enumsForName:(SDLName)name { |
There was a problem hiding this comment.
If sdl_enumsForName: just does sdl_objectForName:, should we remove that function and just use sdl_objectForName:?
* Remove a helper method that’s not needed
|
@asm09fsu Ready for another review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #507
This PR is ready for review.
Risk
This PR makes major API changes.
Testing Plan
All tests continue to pass.
Summary
This PR changes RPC properties that are currently
NSMutableArrays to beNSArrays instead, and updates breaking code. Note that passing a mutable array to an immutable array parameter is still valid, therefore, some code will not break for end users. However, assigning an immutable array to a mutable variable is an error, and so some code will break.Changelog
Breaking Changes
NSMutableArrayare nowNSArrayinstead.