Feature/struct property rewrite #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erty_rewrite * origin/master: Update documentation Update to v4.4.0 Fixed issue relating to uploading files to Core that was out of memory. Uncommented SDLOasisAddress. Removed unused initializer from DateTime Added more informative description for SendLocation's DateTime. Updated formatting Updated Date/Time documentation. Replaced SendLocation's CGFloat with double. Fixed issues with tests not compiling and giving warnings of extra imports. Added additional initializer for SendLocation Made addressLines property more defined on usage. Added additional initializers for SDLDateTime. Fixed issues with tests not compiling and giving warnings of extra imports. Added missing spec tests Updated to Podspec 4.4.0 Merge remote-tracking branch 'origin/master' into sdl_0004_sendlocation_updates Added support for generic SDLDisplayType. Added support for Waypoint RPCs and notifications. Added support for Send Location updates with delivery mode, time stamp, and address updates. # Conflicts: # SmartDeviceLink/SDLDateTime.m # SmartDeviceLink/SDLDeliveryMode.h # SmartDeviceLink/SDLDeliveryMode.m # SmartDeviceLink/SDLDisplayType.h # SmartDeviceLink/SDLDisplayType.m # SmartDeviceLink/SDLFunctionID.m # SmartDeviceLink/SDLGetWaypoints.h # SmartDeviceLink/SDLGetWaypoints.m # SmartDeviceLink/SDLGetWaypointsResponse.m # SmartDeviceLink/SDLLocationCoordinate.m # SmartDeviceLink/SDLLocationDetails.m # SmartDeviceLink/SDLNames.h # SmartDeviceLink/SDLOasisAddress.m # SmartDeviceLink/SDLOnWaypointChange.m # SmartDeviceLink/SDLSendLocation.h # SmartDeviceLink/SDLSendLocation.m # SmartDeviceLink/SDLSubscribeWaypoints.m # SmartDeviceLink/SDLSubscribeWaypointsResponse.m # SmartDeviceLink/SDLUnsubscribeWaypoints.m # SmartDeviceLink/SDLUnsubscribeWaypointsResponse.m # SmartDeviceLink/SDLUploadFileOperation.m # SmartDeviceLink/SDLWaypointType.h # SmartDeviceLink/SDLWaypointType.m # SmartDeviceLinkTests/ProtocolSpecs/SDLFunctionIDSpec.m # SmartDeviceLinkTests/RPCSpecs/EnumSpecs/SDLDeliveryModeSpec.m # SmartDeviceLinkTests/RPCSpecs/EnumSpecs/SDLDisplayTypeSpec.m # SmartDeviceLinkTests/RPCSpecs/EnumSpecs/SDLWaypointTypeSpec.m # SmartDeviceLinkTests/RPCSpecs/NotificationSpecs/SDLOnWaypointChangeSpec.m # SmartDeviceLinkTests/RPCSpecs/RequestSpecs/SDLGetWaypointsSpec.m # SmartDeviceLinkTests/RPCSpecs/RequestSpecs/SDLSendLocationSpec.m # SmartDeviceLinkTests/RPCSpecs/ResponseSpecs/SDLGetWaypointsResponseSpec.m # SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLDateTimeSpec.m # SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLLocationCoordinateSpec.m # SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLLocationDetailsSpec.m # SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLOasisAddressSpec.m
…class of SDLRPCStruct.
…perty_rewrite * origin/develop: (44 commits) Removed SDLTTSChunkFactory from project. Removed SDLRPCRequestFactory from project. Remove a test focus Fixed test cases Fix podspec not updated with latest version number Update for v4.5.0 Follow style guide for boolean check Updated formatting of README.md Removed nonexistent implementation file from project. Added steps for using the lock screen manager from SDL's bundle to the readme. Added check when trying to upload an appIcon for a head unit that does not support graphics. Update for v4.5.0 Fixed issue with trying to upload a file that is nil will cause an infinite loop. Fixed an issue with initializer causing infinite loop. Improved readability for nil-checks. Fixed issue relating to SDLLocationDetails' searchAddress using the wrong key for object store. Fixed formatting for some interfaces. Fixed issue with LocationDetails' properties not properly becoming initialized. Fixed issue with waypoints not being correctly initialized as SDLLocationDetails Adding in nil checks for completion handlers of Streaming Media Manager. ... # Conflicts: # SmartDeviceLink/SDLDateTime.m # SmartDeviceLink/SDLGetWaypoints.m # SmartDeviceLink/SDLGetWaypointsResponse.m # SmartDeviceLink/SDLLocationCoordinate.m # SmartDeviceLink/SDLLocationDetails.m # SmartDeviceLink/SDLOasisAddress.m # SmartDeviceLink/SDLOnWaypointChange.m # SmartDeviceLink/SDLSendLocation.m # SmartDeviceLink/SDLUnsubscribeWaypoints.m # SmartDeviceLink/SDLUnsubscribeWaypointsResponse.m # SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLLocationDetailsSpec.m
…o remove build warning of redefinition
joeljfischer
approved these changes
Jan 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #493
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
These changes can be tested using the included Unit Tests
Summary
This PR modifies all the internal code for the setting and getting of properties in Structs and RPCs, allowing us to use a generic line of code instead of rewriting the same implementation for every new property.
Changelog
Enchancements