SDLJingle 'constants' should be constants.

[justinjdickow]

currently defined as

+(NSString*) NEGATIVE_JINGLE { return @"NEGATIVE_JINGLE"; }
+(NSString*) POSITIVE_JINGLE { return @"POSITIVE_JINGLE"; }
+(NSString*) LISTEN_JINGLE { return @"LISTEN_JINGLE"; }
+(NSString*) INITIAL_JINGLE { return @"INITIAL_JINGLE"; }
+(NSString*) HELP_JINGLE { return @"HELP_JINGLE"; }

see #3 for more information

[joeljfischer]

I'm assuming this was done as a way to namespace constants, but it is definitely inconsistent with best practices for the platform. All of the SDKs string constants are created using standard const variables. An example of what these should look like:

(.m file)
NSString *const SDLJingleNegative = @"NEGATIVE_JINGLE";

[asm09fsu]

This will be resolved in PR #447. Can we close this @joeljfischer ?

[joeljfischer]

Just mention that this is fixed in #447 then

[asm09fsu]

@joeljfischer actually, after looking at this again, SDLJingle has no reason to exist anymore. This is because SDLPrerecordedSpeech contains these exact same constants. Is there another reason this exists?

[joeljfischer]

Don't think so. Needs a prop to remove probably...
On Thu, Sep 22, 2016 at 1:07 AM Alex Muller notifications@github.com
wrote:

@joeljfischer https://github.com/joeljfischer actually, after looking
at this again, SDLJingle has no reason to exist anymore. This is because
SDLPrerecordedSpeech
https://github.com/smartdevicelink/sdl_ios/blob/master/SmartDeviceLink/SDLPrerecordedSpeech.h
contains these exact same constants. Is there another reason this exists?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABr2l66KmqDOmlUUjrdAPJq4es6C3lJ4ks5qsg0DgaJpZM4CyxlO
.

[joeljfischer]

Or, it's probably covered by the enum proposal.

[asm09fsu]

This will be removed in #447

[asm09fsu]

This has been removed in develop.