Feature/sdl 0262 new vehicle data seat occupancy #3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fact file components/application_manager/test/sdl_preloaded_pt.json is a copy of current version of sdl_preloaded_pt.json from AppMain folder. That's why instead of manual update of this copy we can delete it from application_manager/test folder and simply copy actual version of this file from AppMain.
|
@atiwari9 please review this PR |
atiwari9
approved these changes
Dec 3, 2020
There was a problem hiding this comment.
Approved contingent on test scripts Pass test result for: smartdevicelink/sdl_atf_test_scripts#2490
|
@JackLivio This PR is ready for Livio review. Thank you! |
4 tasks
jacobkeeler
requested changes
Dec 18, 2020
5 tasks
jacobkeeler
reviewed
Jan 8, 2021
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
jacobkeeler
approved these changes
Jan 11, 2021
|
@LitvinenkoIra please fix conflicts (should be as simple as updating rpc_spec submodule to latest develop) |
added 2 commits
February 3, 2021 09:39
…ew_vehicle_data_seatOccupancy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3152
This PR is [ready] for review.
Risk
This PR makes [minor] API changes.
Testing Plan
ATF test scripts from smartdevicelink/sdl_atf_test_scripts#2490
Summary
Add new vehicle data SeatOccupancy
Use rpc spec from smartdevicelink/rpc_spec#298
CLA