Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typescript and configure support for GUI #978

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Add typescript and configure support for GUI #978

merged 2 commits into from
Feb 14, 2019

Conversation

rupurt
Copy link
Contributor

@rupurt rupurt commented Feb 13, 2019

[#163414230]

@rupurt rupurt force-pushed the features/typescript branch from 82b0334 to 6ea65de Compare February 13, 2019 20:23
@rupurt rupurt force-pushed the features/react-static-6 branch 4 times, most recently from f1392c4 to cb68634 Compare February 13, 2019 21:02
@rupurt rupurt force-pushed the features/typescript branch from 6ea65de to d2fe40d Compare February 13, 2019 22:20
@rupurt rupurt changed the base branch from features/react-static-6 to master February 13, 2019 23:08
se3000
se3000 previously approved these changes Feb 13, 2019
View reviewed changes
@j16r
Copy link
Contributor

j16r commented Feb 13, 2019

Could we maybe add a single type annotation to our JS to see this working?

@rupurt
Copy link
Contributor Author

rupurt commented Feb 13, 2019 •
edited
Loading

@j16r this file doesn't deal with any types but I converted it to tsx and had to update the modules to relative import syntax. Does that suffice your need to see it working?

I'm working on getting it working for truffle but it seems a little more complicated so want to create a separate PR.

@rupurt rupurt force-pushed the features/typescript branch from d2fe40d to 4efbeca Compare February 13, 2019 23:50
rupurt
rupurt commented Feb 13, 2019
View reviewed changes
gui/src/App.tsx
@@ -13,7 +13,7 @@ class App extends PureComponent {
}
}

render () {
render (): JSX.Element {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j16r return type

@NavyAdmiral
Copy link
Contributor

Awesome! 🥇

@rupurt rupurt merged commit 38caa93 into master Feb 14, 2019
@rupurt rupurt deleted the features/typescript branch February 14, 2019 00:02
@NavyAdmiral NavyAdmiral mentioned this pull request Feb 15, 2019
Closed
asoliman92 added a commit that referenced this pull request Jul 31, 2024
@asoliman92
Feat/ccip 2466 HomeChain config syncer (#978)
a9370e1 
## Motivation

Plugins need to refresh HomeChain config regularly to know which oracles
support which chains and the latest F for each chain.

## Solution

* Add HomeChainConfigPoller which polls chain configs and maps them to internal configs
* Commit plugin uses HomeChainConfigPoller to access required data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j16r j16r j16r approved these changes

@se3000 se3000 se3000 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rupurt @j16r @NavyAdmiral @se3000