-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MicroProfile Telemetry 2.0 #339
Conversation
testsuite/tck/src/test/java/io/smallrye/opentelemetry/tck/TestConfigSource.java
Show resolved
Hide resolved
@radcortez Seems that we need to set |
The Flaky tests are all in the JVM package: https://github.com/eclipse/microprofile-telemetry/tree/877f460eb1c3675102b2b5038cb48dec6d99bf92/tck/metrics/src/main/java/org/eclipse/microprofile/telemetry/metrics/tck/jvm I haven't looked into the details yet. I suspect that the metrics collection for JVM attributes just takes longer than the configured export interval. |
CC @Emily-Jiang |
The problem is that the number of metrics generated cycles the log file, so there may be occasions where the metrics collected are not in the file anymore. The log file cannot be cycled. |
@radcortez @brunobat can you try out this PR to see whether it fixes your issue? |
I have restaged the Telemetry 2.0 release here with the above fix. Please try it out @brunobat @radcortez |
It consistently fails in It seems that with JDK 11, there is not a single GC during the test execution, so the metric is not generated. Apparently it does work by hinting a |
12b8599
to
5944e7e
Compare
No description provided.