Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and Misc changes to Micrometer branch #505

Merged
merged 8 commits into from
Jun 28, 2022
Merged

Fixes and Misc changes to Micrometer branch #505

merged 8 commits into from
Jun 28, 2022

Conversation

Channyboy
Copy link
Contributor

@Channyboy Channyboy commented Jun 20, 2022 •
edited
Loading

  • Use 5.0.0-SNAPSHOT for version
  • Use MP Metrics 5.0.0-SNAPSHOT, see Reduced API  microprofile/microprofile-metrics#664
    • Remove references to removed metrics
  • Fix Missing ThreadLocal usage for Gauges (ThreadLocal used w/ MeterFilter)
  • Fix MetricsMetadata appending scope tag (not needed as its appended to meter on micrometer level w/ filter)
  • quantiles/percentiles (to be configurable) to Timer and Histogram (DistributionSummary)
  • Fix including mp.metrics.appName into MetricID passed to MemberMetricMapping metric maps (probably remove this in the future and query/retrieve directly from metric/meter-registry??)

Changes Probably won't pass the SR build as we can't pull 5.0.0-SNAPSHOT from MP Metrics.

Channyboy added 8 commits June 10, 2022 15:39
@Channyboy
Remove scope appending from MetricsMetadata
c8fbdd8
@Channyboy
ThreadLocals while regsitering/retrieving Gauge in GaugeAdapter and m…
801a718 
…odify LegacyMetricRegistryAdapter to pass metadata for metadata pramed reg/ret for gauge
@Channyboy
include quantiles/percentiles -- to be configurable in future
9b018d3
@Channyboy
change back to 5.0.0-SNAPSHOT
f9fe71a
@Channyboy
Update impl to remove references of ConcurrentGauge, SimpleTimer and …
30b5fac 
…Meter metric types, see MP Metrics PR smallrye#664, TODO: verify JaxrsFilter works
@Channyboy
formatting
3c6f2af
@Channyboy
Include the mp.metrics.appName tag with the MetricID passsed to Membe…
7cfdde3 
…rtoMetricMappings's metric maps, probably remove MembertoMetricMapping one day and direclty query metric/meter-registry
@Channyboy
Use MP Metrics 5.0.0-SNAPSHOT, see MP Metrics PR smallrye#664
97537a9
@Channyboy Channyboy requested a review from jgallimore June 20, 2022 20:41
@jgallimore
Copy link

Thanks for this @Channyboy . I had a couple of conflicting changes locally. I'm just trying this out - I'll aim to get that done today so hopefully we can get this merged in quickly.

@jgallimore jgallimore mentioned this pull request Jun 23, 2022
Closed
@Channyboy Channyboy merged commit f363c7f into smallrye:micrometer Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgallimore jgallimore jgallimore approved these changes

Assignees
No one assigned
Labels
micrometer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Channyboy @jgallimore