Requests without an Accept header are not accepted

Closes #497
smallrye · May 26, 2022 · 721bb8b · 721bb8b
1 parent 256194f
commit 721bb8b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/implementation/src/main/java/io/smallrye/metrics/MetricsRequestHandler.java b/implementation/src/main/java/io/smallrye/metrics/MetricsRequestHandler.java
@@ -264,6 +264,10 @@ Optional<String> getBestMatchingMediaType(Stream<String> acceptHeaders) {
             }
         });
 
+        if (tupleList.isEmpty()) {
+            return Optional.of(TEXT_PLAIN);
+        }
+
         WTTuple bestMatchTuple = new WTTuple(-1, null);
 
         // Iterate over the list and find the best match

diff --git a/implementation/src/test/java/io/smallrye/metrics/MediaHandlerTest.java b/implementation/src/test/java/io/smallrye/metrics/MediaHandlerTest.java
@@ -146,4 +146,11 @@ public void testWithMissingPriorityMulti() {
         assertThat(res.get()).isEqualTo("application/json");
     }
 
+    @Test
+    public void testDefaultMediaTypeWhenAcceptHeaderNotSet() {
+        Optional<String> res = requestHandler.getBestMatchingMediaType(Stream.empty());
+        assertThat(res.isPresent()).isTrue();
+        assertThat(res.get()).isEqualTo("text/plain");
+    }
+
 }