Remove deprecated KeyUtils and ResourceUtils #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeEdgar
approved these changes
Feb 27, 2021
|
@MikeEdgar thanks, I'll wait for a few days in case @darranl and @SoniaZaldana might have some concerns - I'd not expecf this deprecated code be used anywhere in WildFly but just in case :-) |
|
@darranl @SoniaZaldana merging now - any concerns - let me know please here or on the forum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately these are another 2 deprecated classes I forgot to remove before releasing
3.0.0.Both classes are in
jwt-commonnow, in a new packageio.smallrye.jwt.util, the removed classes only delegate to the new classes and have no any specific implementation of their own.I'd not be too concerned if we decided to keep them, I feel it is still safe to remove them instead of carrying this code, but if someone is concerned them let me know please and I'll keep them