Fix JWT build impl to load PEM keys correctly when no default algorithm is used #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radcortez
approved these changes
Jan 21, 2021
|
@radcortez thanks; let me merge this one - @MikeEdgar - any concerns - let me know please, I'll get it into 3.0.0.RC3 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #387
This PR makes sure that the JWT Build signature and encryption implementations pass the expected algorithm to
KeyUtilswhich will help to load it correctly from the PEM file.Also did a minor cleanup in the signature impl, there was a redundant algorithm null check.