Simpler token symmetric signing and encryption support #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeEdgar
previously approved these changes
Aug 26, 2020
Comment on lines
146
to
149
| private SecretKey createSecretKeyFromSecret(String secret) { | ||
| byte[] secretBytes = secret.getBytes(StandardCharsets.UTF_8); | ||
| return new SecretKeySpec(secretBytes, "AES"); | ||
| } |
There was a problem hiding this comment.
Duplicate of JwtBuildUtils.createSecretKeyFromSecret (FYI)
There was a problem hiding this comment.
Hi Mike @MikeEdgar thanks for spotting it, yes, I recall thinking about, I wanted to keep the build related code as isolated as possible in case we consider in time moving it in its own module, but now I've realized this code really belongs in KeyUtils :-). So I've just moved it there, and will merge shortly, cheers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290.
Quarkus users have to manually create
SecretKeywhen they want to sign the token with a password so this PR adds a few shortcuts making it very easy to do.