fix: Update references check #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Lewis <ianlewis@google.com>
asraa
reviewed
Mar 17, 2023
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, edited, reopened, synchronize] |
asraa
approved these changes
Mar 17, 2023
ramonpetgrave64
pushed a commit
to ramonpetgrave64/slsa-verifier
that referenced
this pull request
Apr 18, 2024
* update * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix printing an error in references check. Previously the echoed string was enclosed in double quotes and had backticks which are evaluated as a command. This change changes the string to use single quotes which are printed statically.
Also moves the references check to its own file that triggers when the PR description is updated. This allows for fixing the PR description after failures, and triggering the check to re-run.
/cc @asraa