Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix error logs #356

Merged
merged 1 commit into from
Nov 11, 2022
Merged

fix: fix error logs #356

merged 1 commit into from
Nov 11, 2022

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Nov 11, 2022

Fix error logs.

I guess these codes are copied from the just before error handling mistakenly.

return nil, fmt.Errorf("%w: %s", err, "unable to fetch Rekor public keys from TUF repository")

@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review November 11, 2022 02:46
@suzuki-shunsuke
Copy link
Contributor Author

I think this is a trivial bug fix so an issue is unneeded, but if an issue is needed please let me know.

Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@asraa asraa merged commit f7bd164 into slsa-framework:main Nov 11, 2022
@suzuki-shunsuke suzuki-shunsuke deleted the fix-error-log branch November 11, 2022 23:02
ramonpetgrave64 pushed a commit to ramonpetgrave64/slsa-verifier that referenced this pull request Apr 18, 2024
Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants