Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consolidate verification funcs for GHA #348

Merged
merged 7 commits into from
Nov 2, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Nov 2, 2022

Signed-off-by: Asra Ali asraa@google.com

This consolidates the verification funcs for GHA provenance:

  • Now we use rekor exported verification functions and replace our own verifyRootHash, inclusion proof, and SET verification (all contained in the rverify.VerifyTlogEntry)
  • Factor out the DSSE signature verification

@asraa asraa requested review from laurentsimon and kpk47 November 2, 2022 14:59
Signed-off-by: Asra Ali <asraa@google.com>

fix lint

Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa force-pushed the consolidate-verification branch from dde7777 to 039575f Compare November 2, 2022 15:01
asraa added 4 commits November 2, 2022 10:23
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
verifiers/internal/gha/verifier.go Outdated Show resolved Hide resolved
verifiers/internal/gha/rekor.go Outdated Show resolved Hide resolved
verifiers/internal/gha/provenance.go Outdated Show resolved Hide resolved
asraa added 2 commits November 2, 2022 14:58
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa merged commit ef0f1a7 into slsa-framework:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants