Fix installer: Add arguments to actions/checkout so that it checks ou… #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t slsa-framework/slsa-verifier instead of the repo using the Action. Signed-off-by: kpk47 <kkris@google.com>
laurentsimon
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix installer: Check out the correct repo and fix support for pinning by commit SHA.
I didn't add any tests in this PR because trying to test in this repo covered up these bugs in the first place. Instead, I've opened a corresponding PR against slsa-framework/example-package (slsa-framework/example-package#116). The test fails now, but I'm confident it will succeed based on a separate branch that's targeting the branch this PR is based on (https://github.com/kpk47/example-package/pull/1/files -- ignore the workflow failures. They're due to provenance issues with the slsa-verifier versions built in my fork. The installer logic before the provenance verification works.)