Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pre-submit to catch major version bump #381

Open
laurentsimon opened this issue Dec 2, 2022 · 4 comments
Open

feat: pre-submit to catch major version bump #381

laurentsimon opened this issue Dec 2, 2022 · 4 comments
Labels
area:tests Issue with unit tests area:tooling Issues with project tooling (CI etc.)

Comments

@laurentsimon
Copy link
Contributor

When we bump the major version, we need to update the go.mod and all the imports in the file.

See #299 and #378 for context.

We may want to add pre-release checks to ensure we've done this

@asraa
Copy link
Contributor

asraa commented Dec 2, 2022

How do you think we can programmatically do this? It relies on the tag being created, so maybe it can only effectively happen on the RC's?

We would at some point need to hard-code the go install command.

So the release workflow would do something ike

  1. Tag an RC
  2. Try go install at RC (block here if the module paths weren't updated)
  3. Run build

@laurentsimon
Copy link
Contributor Author

I was thinking doing what you describe manually, and automated only the part to scan the files to verify that the tag in the code are the same as the version we want to cut. It would be a workflow_dispatch trigger that takes as input a version.

But if we do what you describe manually, maybe it'd be good enough.

@laurentsimon
Copy link
Contributor Author

laurentsimon commented Dec 2, 2022

I've thought about it a little more. I think we should have these pre-release checks. Otherwise, we may release a version that internally calls an older version; and even if the installation works, running it may lead to strange results.

Wdut?

@asraa
Copy link
Contributor

asraa commented Dec 2, 2022

I think we have the same thing in mind.

Once we finish creating the RC, we can also create a workflow_dispatch that runs the following 3 checks:

  1. Downloads the RC provenance and verifies
  2. Runs go install
  3. Maybe? Kicks of example-package tests

@ianlewis ianlewis added area:cli An issue with the CLI area:tests Issue with unit tests area:tooling Issues with project tooling (CI etc.) and removed area:cli An issue with the CLI labels Dec 9, 2022
ramonpetgrave64 pushed a commit to ramonpetgrave64/slsa-verifier that referenced this issue Apr 18, 2024
Co-authored-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tests Issue with unit tests area:tooling Issues with project tooling (CI etc.)
Projects
None yet
Development

No branches or pull requests

3 participants