code review comments

slsa-framework · Sep 15, 2022 · a56d945 · a56d945
1 parent 83f3352
commit a56d945
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 12 deletions.
diff --git a/actions/installer/README.md b/actions/installer/README.md
@@ -8,13 +8,7 @@ For more information about SLSA in general, see [https://slsa.dev](https://slsa.
 
 ## Usage
 
-To install the latest version, use:
-
-```yaml
-uses: slsa-framework/slsa-verifier-installer
-```
-
-To install a specific version, use:
+To install a specific version of `slsa-verifier`, use:
 
 ```yaml
 uses: slsa-framework/slsa-verifier-installer@v1.3.0

diff --git a/actions/installer/action.yml b/actions/installer/action.yml
@@ -33,12 +33,12 @@ runs:
       shell: bash
       run: npm ci
 
-    - name: Run build and tests
+    - name: Run build
       working-directory: actions/installer
       shell: bash
-      run: npm run all
+      run: npm run build
 
-    - name: Run test
+    - name: Run installer
       env:
         ACTION_REF: "${{ github.action_ref }}"
         TOKEN: "${{ github.token }}"

diff --git a/actions/installer/package.json b/actions/installer/package.json
@@ -4,13 +4,14 @@
   "description": "",
   "main": "lib/index.js",
   "scripts": {
-    "build": "tsc",
+    "compile": "tsc",
     "format": "prettier --write '**/*.ts'",
     "format-check": "prettier --check '**/*.ts'",
     "test": "jasmine",
     "package": "ncc build --source-map",
     "lint": "eslint src/**/*.ts",
-    "all": "npm run build && npm run format && npm run lint && npm run test && npm run package"
+    "build": "npm run compile && npm run package",
+    "all": "npm run compile && npm run format && npm run lint && npm run test && npm run package"
   },
   "dependencies": {
     "@actions/core": "^1.9.1",